Issue 397513003: InFile.load_from_files should try to load only '.in' files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397513003: InFile.load_from_files should try to load only '.in' files (Closed)

Created:
6 years, 5 months ago by vivekg_samsung

Modified:
6 years, 5 months ago

Reviewers:
vivekg, abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

InFile.load_from_files should try to load only '.in' files InFile.load_from_files() should assert the input file is a '.in' file. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178207

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	Source/build/scripts/in_file.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/build/scripts/in_file_unittest.py	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/397513003/1

6 years, 5 months ago (2014-07-15 19:40:11 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 5 months ago (2014-07-15 20:55:53 UTC) #4

Message was sent while issue was closed.

Change committed as 178207