Source/build/scripts/in_file.py - Issue 397513003: InFile.load_from_files should try to load only '.in' files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/in_file.py

Issue 397513003: InFile.load_from_files should try to load only '.in' files (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/build/scripts/in_file.py

diff --git a/Source/build/scripts/in_file.py b/Source/build/scripts/in_file.py

index d8d8235704b8f142d6e4fccbaa22ce1b0cb4b41b..b33969ecc44b93207b27a07108b5ce59e3a6c5f6 100644

--- a/Source/build/scripts/in_file.py

+++ b/Source/build/scripts/in_file.py

@@ -64,6 +64,7 @@ class InFile(object):

def load_from_files(self, file_paths, defaults, valid_values, default_parameters):

lines = []

for path in file_paths:

+ assert path.endswith(".in")

with open(os.path.abspath(path)) as in_file:

lines += in_file.readlines()

return InFile(lines, defaults, valid_values, default_parameters)

« no previous file with comments | « no previous file | Source/build/scripts/in_file_unittest.py » ('j') | no next file with comments »