Issue 397513002: Fix a newly introduced bug in QUIC's PacingSender where burst_tokens_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397513002: Fix a newly introduced bug in QUIC's PacingSender where burst_tokens_ (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)

Modified:
6 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix a newly introduced bug in QUIC's PacingSender where burst_tokens_ would never be set back to 10 after the initialization, because OnCongestionEvent is never called with bytes_in_flight of 0. Merge internal change: 70371419 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -9 lines)			Patch
M	net/quic/congestion_control/pacing_sender.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/congestion_control/pacing_sender.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/quic/congestion_control/pacing_sender_test.cc	View	1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages