Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: net/quic/congestion_control/pacing_sender.h

Issue 397513002: Fix a newly introduced bug in QUIC's PacingSender where burst_tokens_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | net/quic/congestion_control/pacing_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A send algorithm which adds pacing on top of an another send algorithm. 5 // A send algorithm which adds pacing on top of an another send algorithm.
6 // It uses the underlying sender's bandwidth estimate to determine the 6 // It uses the underlying sender's bandwidth estimate to determine the
7 // pacing rate to be used. It also takes into consideration the expected 7 // pacing rate to be used. It also takes into consideration the expected
8 // resolution of the underlying alarm mechanism to ensure that alarms are 8 // resolution of the underlying alarm mechanism to ensure that alarms are
9 // not set too aggressively, and to smooth out variations. 9 // not set too aggressively, and to smooth out variations.
10 10
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 HasRetransmittableData has_retransmittable_data) const OVERRIDE; 56 HasRetransmittableData has_retransmittable_data) const OVERRIDE;
57 virtual QuicBandwidth BandwidthEstimate() const OVERRIDE; 57 virtual QuicBandwidth BandwidthEstimate() const OVERRIDE;
58 virtual bool HasReliableBandwidthEstimate() const OVERRIDE; 58 virtual bool HasReliableBandwidthEstimate() const OVERRIDE;
59 virtual QuicTime::Delta RetransmissionDelay() const OVERRIDE; 59 virtual QuicTime::Delta RetransmissionDelay() const OVERRIDE;
60 virtual QuicByteCount GetCongestionWindow() const OVERRIDE; 60 virtual QuicByteCount GetCongestionWindow() const OVERRIDE;
61 61
62 private: 62 private:
63 scoped_ptr<SendAlgorithmInterface> sender_; // Underlying sender. 63 scoped_ptr<SendAlgorithmInterface> sender_; // Underlying sender.
64 QuicTime::Delta alarm_granularity_; 64 QuicTime::Delta alarm_granularity_;
65 uint32 initial_packet_burst_; 65 uint32 initial_packet_burst_;
66 uint32 burst_tokens_; 66 mutable uint32 burst_tokens_;
67 // Send time of the last packet considered delayed. 67 // Send time of the last packet considered delayed.
68 QuicTime last_delayed_packet_sent_time_; 68 QuicTime last_delayed_packet_sent_time_;
69 QuicTime next_packet_send_time_; // When can the next packet be sent. 69 QuicTime next_packet_send_time_; // When can the next packet be sent.
70 mutable bool was_last_send_delayed_; // True when the last send was delayed. 70 mutable bool was_last_send_delayed_; // True when the last send was delayed.
71 bool has_valid_rtt_; // True if we have at least one RTT update. 71 bool has_valid_rtt_; // True if we have at least one RTT update.
72 72
73 DISALLOW_COPY_AND_ASSIGN(PacingSender); 73 DISALLOW_COPY_AND_ASSIGN(PacingSender);
74 }; 74 };
75 75
76 } // namespace net 76 } // namespace net
77 77
78 #endif // NET_QUIC_CONGESTION_CONTROL_PACING_SENDER_H_ 78 #endif // NET_QUIC_CONGESTION_CONTROL_PACING_SENDER_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/congestion_control/pacing_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698