Mojo: Correctly handle large unsigned integer literals.

Mojo: Correctly handle large unsigned integer literals.

This adds U suffixes to literals for unsigned int types in C++. For
Java, because integer literals >= 2 ** 63 are not allowed, such values
are transformed to the equivalent 64 bit signed value.

BUG=375522
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283487

[viettrungluu, 2014-07-15 16:08:27]

Thanks. LGTM w/questions.

https://codereview.chromium.org/397453004/diff/40001/mojo/apps/js/bindings/sa...
File mojo/apps/js/bindings/sample_service_unittests.js (right):

https://codereview.chromium.org/397453004/diff/40001/mojo/apps/js/bindings/sa...
mojo/apps/js/bindings/sample_service_unittests.js:109: // JS doesn't have a 64
bit integer type so this is just checking that the
Partly/vaguely implied by my parenthetical comment is the question of whether we
should have additional methods to get an exact representation of 64-bit types in
JS (e.g., as a high-/low-order pair of numbers or as an ArrayBuffer). Probably
we should, in which case I guess I should file a bug for that.

(Also, I suppose if we were keen, we'd test that we get exact integers at least
out to +/- 2^52 or whatever it is.)

https://codereview.chromium.org/397453004/diff/40001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/397453004/diff/40001/mojo/public/tools/bindin...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:37: mojom.UINT64:  
    "U",
Maybe this should be "ULL"?

https://codereview.chromium.org/397453004/diff/40001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/generators/mojom_java_generator.py (right):

https://codereview.chromium.org/397453004/diff/40001/mojo/public/tools/bindin...
mojo/public/tools/bindings/generators/mojom_java_generator.py:237: if
re.match('^[0-9]+$', token):
Side question: This fails to add the L suffix to "big" negative literals, does
it? If so, feel free to file a bug and fix it....

[Sam McNally, 2014-07-16 01:20:18]

https://codereview.chromium.org/397453004/diff/40001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/397453004/diff/40001/mojo/public/tools/bindin...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:37: mojom.UINT64:  
    "U",
On 2014/07/15 16:08:26, viettrungluu wrote:
> Maybe this should be "ULL"?

Done.

https://codereview.chromium.org/397453004/diff/40001/mojo/public/tools/bindin...
File mojo/public/tools/bindings/generators/mojom_java_generator.py (right):

https://codereview.chromium.org/397453004/diff/40001/mojo/public/tools/bindin...
mojo/public/tools/bindings/generators/mojom_java_generator.py:237: if
re.match('^[0-9]+$', token):
On 2014/07/15 16:08:26, viettrungluu wrote:
> Side question: This fails to add the L suffix to "big" negative literals, does
> it? If so, feel free to file a bug and fix it....

Filed https://crbug.com/394186.

[Sam McNally, 2014-07-16 01:39:59]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-07-16 01:43:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/397453004/60001

[commit-bot: I haz the power, 2014-07-16 20:32:47]

Change committed as 283487