Mojo: Correctly handle large unsigned integer literals.

mojo/public/tools/bindings/generators/mojom_java_generator.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates java source files from a mojom.Module."""
 
 import argparse
 import os
 import re
 
@@ skipping 216 matching lines @@
     if not isinstance(named_value, mojom.EnumValue):
       entity_name = (GetConstantsMainEntityName(named_value.module) + '.' +
                       entity_name)
     if GetPackage(named_value.module) == GetPackage(context.resolve('module')):
       return entity_name
     return GetPackage(named_value.module) + '.' + entity_name
 
   if isinstance(token, mojom.NamedValue):
     return _TranslateNamedValue(token)
   # Add Long suffix to all number literals.
   if re.match('^[0-9]+$', token):

[viettrungluu, 2014/07/15 16:08:26]

Side question: This fails to add the L suffix to "big" negative literals, does
it? If so, feel free to file a bug and fix it....

[Sam McNally, 2014/07/16 01:20:18]

Filed https://crbug.com/394186.

-    return token + 'L'
+    number = int(token)
+    # If the literal is too large to fit a signed long, convert it to the
+    # equivalent signed long.
+    if number >= 2 ** 63:
+      number -= 2 ** 64
+    return '%dL' % number
   return token
 
 def IsPointerArrayKind(kind):
   if not IsArray(kind):
     return False
   sub_kind = kind.kind
   return generator.IsObjectKind(sub_kind)
 
 def GetConstantsMainEntityName(module):
   if 'JavaConstantsClassName' in module.attributes:
@@ skipping 88 matching lines @@
   def GetJinjaParameters(self):
     return {
       'lstrip_blocks': True,
       'trim_blocks': True,
     }
 
   def GetGlobals(self):
     return {
       'module': self.module,
     }