Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 397403002: Make MediaQueryList an ActiveDOMElement (Closed)

Created:
6 years, 5 months ago by cbiesinger
Modified:
6 years, 5 months ago
Reviewers:
tkent, abarth-chromium
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-css, blink-reviews-html_chromium.org, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Make MediaQueryList an ActiveDOMElement This ensures that we never GC a MediaQueryList that has listeners. It looks like that already doesn't happen (perhaps due to how MediaQueryListListener keeps references to the JS object), but this seems safer. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178506

Patch Set 1 #

Patch Set 2 : rebased to new namespace na,me #

Patch Set 3 : need ActiveDOMObject in IDL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
A + LayoutTests/fast/media/media-query-listener-gc.html View 3 chunks +6 lines, -9 lines 0 comments Download
A + LayoutTests/fast/media/media-query-listener-gc-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryList.h View 1 4 chunks +8 lines, -4 lines 0 comments Download
M Source/core/css/MediaQueryList.cpp View 1 2 chunks +13 lines, -5 lines 0 comments Download
M Source/core/css/MediaQueryList.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/MediaQueryMatcher.cpp View 1 2 chunks +1 line, -9 lines 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
cbiesinger
6 years, 5 months ago (2014-07-18 00:00:12 UTC) #1
tkent
lgtm
6 years, 5 months ago (2014-07-18 01:40:36 UTC) #2
cbiesinger
Turns out the oilpan bots were failing because I did not know that I need ...
6 years, 5 months ago (2014-07-18 23:14:08 UTC) #3
cbiesinger
The CQ bit was checked by cbiesinger@chromium.org
6 years, 5 months ago (2014-07-18 23:14:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/397403002/40001
6 years, 5 months ago (2014-07-18 23:14:47 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-19 00:38:13 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 01:26:34 UTC) #7
Message was sent while issue was closed.
Change committed as 178506

Powered by Google App Engine
This is Rietveld 408576698