Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: Source/core/css/MediaQueryMatcher.cpp

Issue 397403002: Make MediaQueryList an ActiveDOMElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: need ActiveDOMObject in IDL Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQueryList.idl ('k') | Source/core/html/HTMLSourceElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaQueryMatcher.cpp
diff --git a/Source/core/css/MediaQueryMatcher.cpp b/Source/core/css/MediaQueryMatcher.cpp
index 852963d8ba4034286ae144dc303bc81145298128..12d21b0148b004e3fbec10a2b2f61028124f7164 100644
--- a/Source/core/css/MediaQueryMatcher.cpp
+++ b/Source/core/css/MediaQueryMatcher.cpp
@@ -48,14 +48,6 @@ void MediaQueryMatcher::documentDetached()
{
m_document = nullptr;
m_evaluator = nullptr;
-
- // Take a ref to each MediaQueryList as removing the listeners in documentDetached
- // could release the last ref and mutate the m_mediaLists.
- WillBeHeapVector<RefPtrWillBeMember<MediaQueryList> > lists;
- copyToVector(m_mediaLists, lists);
-
- for (size_t i = 0; i < lists.size(); ++i)
- lists[i]->documentDetached();
}
PassOwnPtr<MediaQueryEvaluator> MediaQueryMatcher::createEvaluator() const
@@ -91,7 +83,7 @@ PassRefPtrWillBeRawPtr<MediaQueryList> MediaQueryMatcher::matchMedia(const Strin
RefPtrWillBeRawPtr<MediaQuerySet> media = MediaQuerySet::create(query);
// Add warning message to inspector whenever dpi/dpcm values are used for "screen" media.
reportMediaQueryWarningIfNeeded(m_document, media.get());
- return MediaQueryList::create(this, media);
+ return MediaQueryList::create(m_document, this, media);
}
void MediaQueryMatcher::addMediaQueryList(MediaQueryList* query)
« no previous file with comments | « Source/core/css/MediaQueryList.idl ('k') | Source/core/html/HTMLSourceElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698