Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: Source/devtools/front_end/timeline/TracingTimelineModel.js

Issue 397313003: DevTools: Remove target function from TimelineModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TracingTimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TracingTimelineModel.js b/Source/devtools/front_end/timeline/TracingTimelineModel.js
index ba539129b15c658676489cf81855768ee29cb4bc..095e57bd761357a17e1135c21355bb551208e5df 100644
--- a/Source/devtools/front_end/timeline/TracingTimelineModel.js
+++ b/Source/devtools/front_end/timeline/TracingTimelineModel.js
@@ -10,7 +10,7 @@
*/
WebInspector.TracingTimelineModel = function(tracingModel, recordFilter)
{
- WebInspector.TimelineModel.call(this, tracingModel.target());
+ WebInspector.TimelineModel.call(this);
this._tracingModel = tracingModel;
this._inspectedTargetEvents = [];
this._recordFilter = recordFilter;
@@ -617,7 +617,8 @@ WebInspector.TracingTimelineModel.TraceEventRecord.prototype = {
*/
target: function()
{
- return this._model.target();
+ //FIXME: get it from this._event
caseq 2014/07/17 16:36:44 Why not do it now?
sergeyv 2014/07/17 17:07:07 Because thread has nullable target, and Record has
+ return WebInspector.targetManager.targets()[0];
},
/**

Powered by Google App Engine
This is Rietveld 408576698