Source/devtools/front_end/timeline/TimelineTracingView.js - Issue 397313003: DevTools: Remove target function from TimelineModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineTracingView.js

Issue 397313003: DevTools: Remove target function from TimelineModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TracingTimelineModel.js » ('j') | Source/devtools/front_end/timeline/TracingTimelineModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelineTracingView.js

diff --git a/Source/devtools/front_end/timeline/TimelineTracingView.js b/Source/devtools/front_end/timeline/TimelineTracingView.js

index e07032b96a83b066801d712c1bd8588585461757..35b009379a27d72b263268c42fc3c54b105879df 100644

--- a/Source/devtools/front_end/timeline/TimelineTracingView.js

+++ b/Source/devtools/front_end/timeline/TimelineTracingView.js

@@ -135,7 +135,9 @@ WebInspector.TimelineTracingView.prototype = {

var recordTypes = WebInspector.TracingTimelineModel.RecordType;

switch (record.name) {

case recordTypes.PictureSnapshot:

- WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent(this._tracingModel.target(), record.args["snapshot"]["skp64"], appendPreviewAndShowDetails.bind(this));

+ var target = record.thread.target();

+ if (target)

caseq 2014/07/17 16:36:44 We still need to show some details when the target

sergeyv 2014/07/17 17:07:07 Done.

+ WebInspector.TracingTimelineUIUtils.buildPicturePreviewContent(target, record.args["snapshot"]["skp64"], appendPreviewAndShowDetails.bind(this));

break;

case recordTypes.LayerTreeHostImplSnapshot:

var link = document.createElement("span");