Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 397313003: DevTools: Remove target function from TimelineModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index bd2a2acd061aa5d2df5f86e1851c25b9c16b137f..a19d09e7b0f00dcce61d42dd402423ccf77bef5c 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -444,14 +444,12 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
* @implements {WebInspector.TimelineFlameChart.SelectionProvider}
* @param {!WebInspector.TracingTimelineModel} model
* @param {!WebInspector.TimelineFrameModelBase} frameModel
- * @param {!WebInspector.Target} target
*/
-WebInspector.TracingBasedTimelineFlameChartDataProvider = function(model, frameModel, target)
+WebInspector.TracingBasedTimelineFlameChartDataProvider = function(model, frameModel)
{
WebInspector.FlameChartDataProvider.call(this);
this._model = model;
this._frameModel = frameModel;
- this._target = target;
this._font = "12px " + WebInspector.fontFamily();
this._linkifier = new WebInspector.Linkifier();
this._palette = new WebInspector.TraceViewPalette();
@@ -505,7 +503,7 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
if (event) {
var name = WebInspector.TracingTimelineUIUtils.styleForTraceEvent(event.name).title;
// TODO(yurys): support event dividers
- var details = WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event, this._linkifier, false, this._target);
+ var details = WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent(event, this._linkifier);
return details ? WebInspector.UIString("%s (%s)", name, details.textContent) : name;
}
var title = this._entryIndexToTitle[entryIndex];
@@ -856,7 +854,7 @@ WebInspector.TimelineFlameChart = function(delegate, model, tracingModel, frameM
this._delegate = delegate;
this._model = model;
this._dataProvider = tracingModel
- ? new WebInspector.TracingBasedTimelineFlameChartDataProvider(tracingModel, frameModel, model.target())
+ ? new WebInspector.TracingBasedTimelineFlameChartDataProvider(tracingModel, frameModel)
: new WebInspector.TimelineFlameChartDataProvider(/** @type {!WebInspector.TimelineModelImpl} */(model), frameModel, uiUtils);
this._mainView = new WebInspector.FlameChart(this._dataProvider, this, true);
this._mainView.show(this.element);

Powered by Google App Engine
This is Rietveld 408576698