Make goma work for the GN build on linux.

Make goma work for the GN build on linux.

This drops the old gyp-compatible settings and wires up the
Linux and Android toolchains to be goma-aware. Mac and Win can
follow in subsequent CLs.

R=brettw@chromium.org, thakis@chromium.org
BUG=394501
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283971

[Dirk Pranke, 2014-07-17 01:18:28]

https://codereview.chromium.org/397173004/diff/1/build/toolchain/goma.gni
File build/toolchain/goma.gni (left):

https://codereview.chromium.org/397173004/diff/1/build/toolchain/goma.gni#old...
build/toolchain/goma.gni:31: }
I believe this was only used by the GN/GYP hybrid build, which we no longer
really support, so this is safe to be deleted. Correct me if I'm wrong ...

https://codereview.chromium.org/397173004/diff/1/build/toolchain/linux/BUILD.gn
File build/toolchain/linux/BUILD.gn (right):

https://codereview.chromium.org/397173004/diff/1/build/toolchain/linux/BUILD....
build/toolchain/linux/BUILD.gn:18: cxx = "${goma_prefix}arm-linux-gnueabi-g++"
this seemed like the safest and clearest approach to me, but perhaps you might
have other ideas.

https://codereview.chromium.org/397173004/diff/1/build/toolchain/linux/BUILD....
build/toolchain/linux/BUILD.gn:90: gcc_toolchain("mipsel") {
any idea if goma supports the mipsel toolchain?

[Nico, 2014-07-17 01:21:47]

https://codereview.chromium.org/397173004/diff/1/build/toolchain/linux/BUILD.gn
File build/toolchain/linux/BUILD.gn (right):

https://codereview.chromium.org/397173004/diff/1/build/toolchain/linux/BUILD....
build/toolchain/linux/BUILD.gn:90: gcc_toolchain("mipsel") {
On 2014/07/17 01:18:27, Dirk Pranke wrote:
> any idea if goma supports the mipsel toolchain? 

As far as I know, no. I'm aware of a single mips bot on the internal android
waterfall (which doesn't use goma); the other mips bots are external (
http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for...
) and can't use goma for that reason.

[Nico, 2014-07-17 01:22:52]

The change makes sense to me (and it looks so much nicer than in gyp!), but
Brett should look too.

[brettw, 2014-07-17 04:37:30]

LGTM

https://codereview.chromium.org/397173004/diff/1/build/toolchain/goma.gni
File build/toolchain/goma.gni (left):

https://codereview.chromium.org/397173004/diff/1/build/toolchain/goma.gni#old...
build/toolchain/goma.gni:31: }
Correct.

https://codereview.chromium.org/397173004/diff/1/build/toolchain/linux/BUILD.gn
File build/toolchain/linux/BUILD.gn (right):

https://codereview.chromium.org/397173004/diff/1/build/toolchain/linux/BUILD....
build/toolchain/linux/BUILD.gn:90: gcc_toolchain("mipsel") {
I don't touch any mips thing. The mips people contributed it and maintain it.

[Dirk Pranke, 2014-07-17 21:25:42]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-07-17 21:29:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dpranke@chromium.org/397173004/1

[commit-bot: I haz the power, 2014-07-18 01:51:12]

Change committed as 283971