build/toolchain/goma.gni - Issue 397173004: Make goma work for the GN build on linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/goma.gni

Issue 397173004: Make goma work for the GN build on linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/goma.gni

diff --git a/build/toolchain/goma.gni b/build/toolchain/goma.gni

index 1f34723ad42f48a57fb5ab151b1667d854380614..c0f4cf2825289f9bccaba909318d1e1d535b9f55 100644

--- a/build/toolchain/goma.gni

+++ b/build/toolchain/goma.gni

@@ -20,12 +20,3 @@ declare_args() {

goma_dir = getenv("HOME") + "/goma"

}

-if (use_goma) {

- # Define the toolchain for the GYP build when using goma.

- make_goma_global_settings =

- "['CC_wrapper', '$goma_dir/gomacc']," +

- "['CXX_wrapper', '$goma_dir/gomacc']," +

- "['CC.host_wrapper', '$goma_dir/gomacc']," +

- "['CXX.host_wrapper', '$goma_dir/gomacc'],"

Dirk Pranke 2014/07/17 01:18:27 I believe this was only used by the GN/GYP hybrid

brettw 2014/07/17 04:37:30 Correct.

« no previous file with comments | « no previous file | build/toolchain/linux/BUILD.gn » ('j') | build/toolchain/linux/BUILD.gn » ('J')