Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 397023002: Remove the un-needed duplicated tests for kDisableAudioTrackProcessing (Closed)

Created:
6 years, 5 months ago by no longer working on chromium
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove the un-needed duplicated tests for kDisableAudioTrackProcessing. The fact is that the code behind kDisableAudioTrackProcessing is deprecating, and these tests are run two times now, one with kDisableAudioTrackProcessing, one without. This generates noise when tests are flaky on Android. NOTRY=true BUG=387895 TEST=bots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283700

Patch Set 1 #

Patch Set 2 : fixed the bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -102 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 4 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 18 chunks +31 lines, -45 lines 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 22 chunks +22 lines, -36 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
no longer working on chromium
Henrik, could you please take a look at this CL? Thanks, SX
6 years, 5 months ago (2014-07-16 14:55:32 UTC) #1
henrika (OOO until Aug 14)
LGTM.
6 years, 5 months ago (2014-07-16 14:56:52 UTC) #2
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 5 months ago (2014-07-16 15:01:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/397023002/1
6 years, 5 months ago (2014-07-16 15:02:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 19:28:04 UTC) #5
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 5 months ago (2014-07-16 19:47:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/397023002/20001
6 years, 5 months ago (2014-07-16 19:48:56 UTC) #7
no longer working on chromium
The CQ bit was unchecked by xians@chromium.org
6 years, 5 months ago (2014-07-17 07:53:53 UTC) #8
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 5 months ago (2014-07-17 07:53:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/397023002/20001
6 years, 5 months ago (2014-07-17 07:55:29 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 08:02:11 UTC) #11
Message was sent while issue was closed.
Change committed as 283700

Powered by Google App Engine
This is Rietveld 408576698