| Index: content/browser/media/webrtc_getusermedia_browsertest.cc
|
| diff --git a/content/browser/media/webrtc_getusermedia_browsertest.cc b/content/browser/media/webrtc_getusermedia_browsertest.cc
|
| index 8821d64f458ac2e53e5f538e02e86b63b89a544a..8af8f45621b1a52f052975c49c4d19a51432134d 100644
|
| --- a/content/browser/media/webrtc_getusermedia_browsertest.cc
|
| +++ b/content/browser/media/webrtc_getusermedia_browsertest.cc
|
| @@ -75,20 +75,11 @@ std::string GenerateGetUserMediaWithOptionalSourceID(
|
|
|
| namespace content {
|
|
|
| -class WebRtcGetUserMediaBrowserTest: public WebRtcContentBrowserTest,
|
| - public testing::WithParamInterface<bool> {
|
| +class WebRtcGetUserMediaBrowserTest: public WebRtcContentBrowserTest {
|
| public:
|
| WebRtcGetUserMediaBrowserTest() : trace_log_(NULL) {}
|
| virtual ~WebRtcGetUserMediaBrowserTest() {}
|
|
|
| - virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
|
| - WebRtcContentBrowserTest::SetUpCommandLine(command_line);
|
| -
|
| - bool enable_audio_track_processing = GetParam();
|
| - if (!enable_audio_track_processing)
|
| - command_line->AppendSwitch(switches::kDisableAudioTrackProcessing);
|
| - }
|
| -
|
| void StartTracing() {
|
| CHECK(trace_log_ == NULL) << "Can only can start tracing once";
|
| trace_log_ = base::debug::TraceLog::GetInstance();
|
| @@ -242,15 +233,10 @@ class WebRtcGetUserMediaBrowserTest: public WebRtcContentBrowserTest,
|
| scoped_refptr<MessageLoopRunner> message_loop_runner_;
|
| };
|
|
|
| -static const bool kRunTestsWithFlag[] = { false, true };
|
| -INSTANTIATE_TEST_CASE_P(WebRtcGetUserMediaBrowserTests,
|
| - WebRtcGetUserMediaBrowserTest,
|
| - testing::ValuesIn(kRunTestsWithFlag));
|
| -
|
| // These tests will all make a getUserMedia call with different constraints and
|
| // see that the success callback is called. If the error callback is called or
|
| // none of the callbacks are called the tests will simply time out and fail.
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest, GetVideoStreamAndStop) {
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest, GetVideoStreamAndStop) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
|
| @@ -260,7 +246,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest, GetVideoStreamAndStop) {
|
| base::StringPrintf("%s({video: true});", kGetUserMediaAndStop));
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| RenderSameTrackMediastreamAndStop) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -272,7 +258,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| kRenderSameTrackMediastreamAndStop));
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| RenderClonedMediastreamAndStop) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -285,7 +271,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| kRenderClonedMediastreamAndStop));
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| kRenderClonedTrackMediastreamAndStop) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -297,7 +283,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| kRenderClonedTrackMediastreamAndStop));
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| kRenderDuplicatedMediastreamAndStop) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -316,7 +302,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| #define MAYBE_GetAudioAndVideoStreamAndStop GetAudioAndVideoStreamAndStop
|
| #endif
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| MAYBE_GetAudioAndVideoStreamAndStop) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -327,7 +313,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| "%s({video: true, audio: true});", kGetUserMediaAndStop));
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| GetAudioAndVideoStreamAndClone) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -337,7 +323,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| ExecuteJavascriptAndWaitForOk("getUserMediaAndClone();");
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| RenderVideoTrackInMultipleTagsAndPause) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -349,7 +335,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
|
|
|
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| GetUserMediaWithMandatorySourceID) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -374,7 +360,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| }
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| GetUserMediaWithInvalidMandatorySourceID) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -407,7 +393,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| video_ids[0])));
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| GetUserMediaWithInvalidOptionalSourceID) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -440,7 +426,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| video_ids[0])));
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest, TwoGetUserMediaAndStop) {
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest, TwoGetUserMediaAndStop) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
|
| @@ -450,7 +436,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest, TwoGetUserMediaAndStop) {
|
| "twoGetUserMediaAndStop({video: true, audio: true});");
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| TwoGetUserMediaWithEqualConstraints) {
|
| std::string constraints1 = "{video: true, audio: true}";
|
| const std::string& constraints2 = constraints1;
|
| @@ -460,7 +446,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| expected_result);
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| TwoGetUserMediaWithSecondVideoCropped) {
|
| std::string constraints1 = "{video: true}";
|
| std::string constraints2 = "{video: {mandatory: {maxHeight: 360}}}";
|
| @@ -469,7 +455,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| expected_result);
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| TwoGetUserMediaWithFirstHdSecondVga) {
|
| std::string constraints1 =
|
| "{video: {mandatory: {minWidth:1280 , minHeight: 720}}}";
|
| @@ -480,7 +466,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| expected_result);
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| TwoGetUserMediaAndVerifyFrameRate) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -499,7 +485,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| ExecuteJavascriptAndWaitForOk(command);
|
| }
|
|
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| GetUserMediaWithTooHighVideoConstraintsValues) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -523,7 +509,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| // in a simple local <video>, and for a couple of seconds, collect some
|
| // performance traces from VideoCaptureController colorspace conversion and
|
| // potential resizing.
|
| -IN_PROC_BROWSER_TEST_P(
|
| +IN_PROC_BROWSER_TEST_F(
|
| WebRtcGetUserMediaBrowserTest,
|
| TraceVideoCaptureControllerPerformanceDuringGetUserMedia) {
|
| RunGetUserMediaAndCollectMeasures(
|
| @@ -533,7 +519,7 @@ IN_PROC_BROWSER_TEST_P(
|
| }
|
|
|
| // This test calls getUserMedia and checks for aspect ratio behavior.
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| TestGetUserMediaAspectRatio4To3) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -548,7 +534,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| }
|
|
|
| // This test calls getUserMedia and checks for aspect ratio behavior.
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| TestGetUserMediaAspectRatio16To9) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
| @@ -563,7 +549,7 @@ IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| }
|
|
|
| // This test calls getUserMedia and checks for aspect ratio behavior.
|
| -IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
|
| +IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
|
| TestGetUserMediaAspectRatio1To1) {
|
| ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
|
|
|
|
|