Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 396973002: Password bubble: Don't focus by default. (Closed)

Created:
6 years, 5 months ago by vasilii
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

Password bubble: Don't focus by default. This is the duplicate of https://codereview.chromium.org/373043003. The bubble turned to be unresponsive on Windows. This CL has a workaround. The original problem is in infrastructure. It's to be fixed in BubbleDelegateView. set_use_focusless(true) has adverse effect on Windows. 1) The bubble can't be the active window (which is not desired behavior). 2) The bubble doesn't get WM_LBUTTONDOWN event. Therefore, all the buttons get stuck. We call set_use_focusless(false) after the bubble is shown. Thus, it can get focus and mouse events properly. BUG=383821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283548

Patch Set 1 #

Patch Set 2 : comment + test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 3 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vasilii
Hi guys, please review.
6 years, 5 months ago (2014-07-16 09:39:16 UTC) #1
Mike West
On 2014/07/16 09:39:16, vasilii wrote: > Hi guys, > > please review. What is the ...
6 years, 5 months ago (2014-07-16 09:43:37 UTC) #2
vabr (Chromium)
On 2014/07/16 09:39:16, vasilii wrote: > Hi guys, > > please review. Thanks for fixing ...
6 years, 5 months ago (2014-07-16 09:46:48 UTC) #3
Mike West
Thanks for the explanation! As discussed: 1. Add a note to both the new line ...
6 years, 5 months ago (2014-07-16 10:37:17 UTC) #4
vasilii
Done.
6 years, 5 months ago (2014-07-16 11:25:31 UTC) #5
Mike West
LGTM, thanks for taking another pass.
6 years, 5 months ago (2014-07-16 11:35:24 UTC) #6
vasilii
The CQ bit was checked by vasilii@chromium.org
6 years, 5 months ago (2014-07-16 11:40:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/396973002/20001
6 years, 5 months ago (2014-07-16 11:42:02 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 22:28:29 UTC) #9
Message was sent while issue was closed.
Change committed as 283548

Powered by Google App Engine
This is Rietveld 408576698