Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 373043003: Password bubble: Don't focus by default. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Password bubble: Don't focus by default. BUG=383821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281809

Patch Set 1 #

Total comments: 1

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Would you mind taking a look, Vaclav? -mike
6 years, 5 months ago (2014-07-08 09:44:09 UTC) #1
vabr (Chromium)
LGTM, looking forward to the unfocussed bubble! Cheers, Vaclav https://codereview.chromium.org/373043003/diff/1/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc File chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc (right): https://codereview.chromium.org/373043003/diff/1/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc#newcode84 chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc:84: ...
6 years, 5 months ago (2014-07-08 11:41:39 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-08 11:51:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/373043003/20001
6 years, 5 months ago (2014-07-08 11:52:06 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 20:14:10 UTC) #5
Message was sent while issue was closed. 
Change committed as 281809

Powered by Google App Engine
This is Rietveld 408576698