Source/modules/push_messaging/PushRegistration.h - Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushRegistration.h

Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remake (add WebType::dispose()) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/modules/push_messaging/PushError.cpp ('k') | Source/modules/serviceworkers/ServiceWorker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushRegistration.h

diff --git a/Source/modules/push_messaging/PushRegistration.h b/Source/modules/push_messaging/PushRegistration.h

index c7ccea7d2c5a20731c03130769f6230f1386d6de..4fa02408b57eeb7de96db110366c679822d774d0 100644

--- a/Source/modules/push_messaging/PushRegistration.h

+++ b/Source/modules/push_messaging/PushRegistration.h

@@ -24,6 +24,10 @@ public:

OwnPtr<WebType> registration = adoptPtr(registrationRaw);

return new PushRegistration(registration->endpoint, registration->registrationId);

}

+ static void dispose(WebType* registrationRaw)

+ {

+ delete registrationRaw;

+ }

virtual ~PushRegistration();