Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: Source/modules/push_messaging/PushRegistration.h

Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remake (add WebType::dispose()) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PushRegistration_h 5 #ifndef PushRegistration_h
6 #define PushRegistration_h 6 #define PushRegistration_h
7 7
8 #include "bindings/core/v8/ScriptWrappable.h" 8 #include "bindings/core/v8/ScriptWrappable.h"
9 #include "platform/heap/Handle.h" 9 #include "platform/heap/Handle.h"
10 #include "public/platform/WebPushRegistration.h" 10 #include "public/platform/WebPushRegistration.h"
11 #include "wtf/OwnPtr.h" 11 #include "wtf/OwnPtr.h"
12 #include "wtf/text/WTFString.h" 12 #include "wtf/text/WTFString.h"
13 13
14 namespace WebCore { 14 namespace WebCore {
15 15
16 class ScriptPromiseResolver; 16 class ScriptPromiseResolver;
17 17
18 class PushRegistration FINAL : public GarbageCollectedFinalized<PushRegistration >, public ScriptWrappable { 18 class PushRegistration FINAL : public GarbageCollectedFinalized<PushRegistration >, public ScriptWrappable {
19 public: 19 public:
20 // For CallbackPromiseAdapter. 20 // For CallbackPromiseAdapter.
21 typedef blink::WebPushRegistration WebType; 21 typedef blink::WebPushRegistration WebType;
22 static PushRegistration* from(ScriptPromiseResolver*, WebType* registrationR aw) 22 static PushRegistration* from(ScriptPromiseResolver*, WebType* registrationR aw)
23 { 23 {
24 OwnPtr<WebType> registration = adoptPtr(registrationRaw); 24 OwnPtr<WebType> registration = adoptPtr(registrationRaw);
25 return new PushRegistration(registration->endpoint, registration->regist rationId); 25 return new PushRegistration(registration->endpoint, registration->regist rationId);
26 } 26 }
27 static void dispose(WebType* registrationRaw)
28 {
29 delete registrationRaw;
30 }
27 31
28 virtual ~PushRegistration(); 32 virtual ~PushRegistration();
29 33
30 const String& pushEndpoint() const { return m_pushEndpoint; } 34 const String& pushEndpoint() const { return m_pushEndpoint; }
31 const String& pushRegistrationId() const { return m_pushRegistrationId; } 35 const String& pushRegistrationId() const { return m_pushRegistrationId; }
32 36
33 void trace(Visitor*) { } 37 void trace(Visitor*) { }
34 38
35 private: 39 private:
36 PushRegistration(const String& pushEndpoint, const String& pushRegistrationI d); 40 PushRegistration(const String& pushEndpoint, const String& pushRegistrationI d);
37 41
38 String m_pushEndpoint; 42 String m_pushEndpoint;
39 String m_pushRegistrationId; 43 String m_pushRegistrationId;
40 }; 44 };
41 45
42 } // namespace WebCore 46 } // namespace WebCore
43 47
44 #endif // PushRegistration_h 48 #endif // PushRegistration_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698