Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 396853003: cc: Add TODO's in ScopedGpuRaster. (Closed)

Created:
6 years, 5 months ago by sohanjg
Modified:
5 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Add TODO's in ScopedGpuRaster. TestContextProvider returns NULL GrContext now, adding todo's to make it clear that code path is used only because of that shortcoming. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283853

Patch Set 1 #

Patch Set 2 : add space for presubmit check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cc/resources/scoped_gpu_raster.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sohanjg
Can you please take a look, Thanks.
6 years, 5 months ago (2014-07-17 09:08:17 UTC) #1
danakj
LGTM thanks
6 years, 5 months ago (2014-07-17 15:09:06 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 5 months ago (2014-07-17 15:09:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sohan.jyoti@samsung.com/396853003/20001
6 years, 5 months ago (2014-07-17 15:10:04 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 20:23:24 UTC) #5
Message was sent while issue was closed.
Change committed as 283853

Powered by Google App Engine
This is Rietveld 408576698