Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: cc/resources/scoped_gpu_raster.cc

Issue 396853003: cc: Add TODO's in ScopedGpuRaster. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add space for presubmit check. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/scoped_gpu_raster.h" 5 #include "cc/resources/scoped_gpu_raster.h"
6 #include "gpu/command_buffer/client/gles2_interface.h" 6 #include "gpu/command_buffer/client/gles2_interface.h"
7 #include "third_party/khronos/GLES2/gl2.h" 7 #include "third_party/khronos/GLES2/gl2.h"
8 #include "third_party/khronos/GLES2/gl2ext.h" 8 #include "third_party/khronos/GLES2/gl2ext.h"
9 #include "third_party/skia/include/gpu/GrContext.h" 9 #include "third_party/skia/include/gpu/GrContext.h"
10 10
(...skipping 12 matching lines...) Expand all
23 23
24 void ScopedGpuRaster::BeginGpuRaster() { 24 void ScopedGpuRaster::BeginGpuRaster() {
25 GLES2Interface* gl = context_provider_->ContextGL(); 25 GLES2Interface* gl = context_provider_->ContextGL();
26 26
27 // TODO(alokp): Use a trace macro to push/pop markers. 27 // TODO(alokp): Use a trace macro to push/pop markers.
28 // Using push/pop functions directly incurs cost to evaluate function 28 // Using push/pop functions directly incurs cost to evaluate function
29 // arguments even when tracing is disabled. 29 // arguments even when tracing is disabled.
30 gl->PushGroupMarkerEXT(0, "GpuRasterization"); 30 gl->PushGroupMarkerEXT(0, "GpuRasterization");
31 31
32 class GrContext* gr_context = context_provider_->GrContext(); 32 class GrContext* gr_context = context_provider_->GrContext();
33 // TODO(sohanjg): Remove when TestContextProvider gives a GrContext.
33 if (gr_context) 34 if (gr_context)
34 gr_context->resetContext(); 35 gr_context->resetContext();
35 } 36 }
36 37
37 void ScopedGpuRaster::EndGpuRaster() { 38 void ScopedGpuRaster::EndGpuRaster() {
38 GLES2Interface* gl = context_provider_->ContextGL(); 39 GLES2Interface* gl = context_provider_->ContextGL();
39 40
40 class GrContext* gr_context = context_provider_->GrContext(); 41 class GrContext* gr_context = context_provider_->GrContext();
42 // TODO(sohanjg): Remove when TestContextProvider gives a GrContext.
41 if (gr_context) 43 if (gr_context)
42 gr_context->flush(); 44 gr_context->flush();
43 45
44 // TODO(alokp): Use a trace macro to push/pop markers. 46 // TODO(alokp): Use a trace macro to push/pop markers.
45 // Using push/pop functions directly incurs cost to evaluate function 47 // Using push/pop functions directly incurs cost to evaluate function
46 // arguments even when tracing is disabled. 48 // arguments even when tracing is disabled.
47 gl->PopGroupMarkerEXT(); 49 gl->PopGroupMarkerEXT();
48 } 50 }
49 51
50 } // namespace cc 52 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698