Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 396843003: Place OEM folder for new users after Web Store (Closed)

Created:
6 years, 5 months ago by stevenjb
Modified:
6 years, 5 months ago
Reviewers:
Dmitry Polukhin, jennyz
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Place OEM folder for new users after Web Store It turns out that on some OEM devices the Files app is placed near the end, so placing the OEM folder before the last non-removable app does not have the desired result. Instead, we place it after the WebStore, and assume that a pre-installed app (e.g. Search) exists so that the app location is stable. This was tested succesfully on an official build on one of the failing devices. (I also confirmed that all of the existing defailt_app_order files have the WebStore followed by Search early in the list). BUG=chrome-os-partner:29764 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 chunk +16 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stevenjb
This time for sure...
6 years, 5 months ago (2014-07-16 00:59:35 UTC) #1
Dmitry Polukhin
lgtm
6 years, 5 months ago (2014-07-16 07:22:50 UTC) #2
jennyz
lgtm
6 years, 5 months ago (2014-07-16 16:29:33 UTC) #3
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 5 months ago (2014-07-16 17:20:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/396843003/1
6 years, 5 months ago (2014-07-16 17:22:22 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 09:05:51 UTC) #6
Message was sent while issue was closed.
Change committed as 283722

Powered by Google App Engine
This is Rietveld 408576698