Place OEM folder for new users after Web Store

chrome/browser/ui/app_list/app_list_syncable_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/app_list_syncable_service.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/apps/drive/drive_app_provider.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 857 matching lines @@
     syncer::StringOrdinal last;
     for (SyncItemMap::iterator iter = sync_items_.begin();
          iter != sync_items_.end(); ++iter) {
       SyncItem* sync_item = iter->second;
       if (!last.IsValid() || sync_item->item_ordinal.GreaterThan(last))
         last = sync_item->item_ordinal;
     }
     return last.CreateAfter();
   }
 
-  // Place the OEM folder just before the last unremovable default item.
-  // Since positions are relative, anywhere else is unstable. TODO(stevenjb):
-  // consider explicitly setting the OEM folder location along with the name in
-  // ServicesCustomizationDocument::SetOemFolderName().
+  // Place the OEM folder just after the web store, which should always be
+  // followed by a pre-installed app (e.g. Search), so the poosition should be
+  // stable. TODO(stevenjb): consider explicitly setting the OEM folder location
+  // along with the name in ServicesCustomizationDocument::SetOemFolderName().
   AppListItemList* item_list = model_->top_level_item_list();
+  if (item_list->item_count() == 0)
+    return syncer::StringOrdinal();
+
   size_t oem_index = 0;
-  for (int i = static_cast<int>(item_list->item_count()) - 1; i >= 0; --i) {
-    AppListItem* cur_item = item_list->item_at(i);
-    const std::string& id = cur_item->id();
-    if (IsUnRemovableDefaultApp(id)) {
-      oem_index = i;
+  for (; oem_index < item_list->item_count() - 1; ++oem_index) {
+    AppListItem* cur_item = item_list->item_at(oem_index);
+    if (cur_item->id() == extension_misc::kWebStoreAppId)
       break;
-    }
   }
   syncer::StringOrdinal oem_ordinal;
-  AppListItem* next = item_list->item_at(oem_index);
-  if (oem_index > 0) {
-    AppListItem* prev = item_list->item_at(oem_index - 1);
+  AppListItem* prev = item_list->item_at(oem_index);
+  if (oem_index + 1 < item_list->item_count()) {
+    AppListItem* next = item_list->item_at(oem_index + 1);
     oem_ordinal = prev->position().CreateBetween(next->position());
   } else {
-    oem_ordinal = next->position().CreateBefore();
+    oem_ordinal = prev->position().CreateAfter();
   }
-  DVLOG(1) << "Placing OEM Folder at: " << oem_index
-           << " position: " << oem_ordinal.ToDebugString();
+  VLOG(1) << "Placing OEM Folder at: " << oem_index
+          << " position: " << oem_ordinal.ToDebugString();
   return oem_ordinal;
 }
 
 bool AppListSyncableService::AppIsOem(const std::string& id) {
   if (!extension_system_->extension_service())
     return false;
   const extensions::Extension* extension =
       extension_system_->extension_service()->GetExtensionById(id, true);
   return extension && extension->was_installed_by_oem();
 }
 
 std::string AppListSyncableService::SyncItem::ToString() const {
   std::string res = item_id.substr(0, 8);
   if (item_type == sync_pb::AppListSpecifics::TYPE_REMOVE_DEFAULT_APP) {
     res += " { RemoveDefault }";
   } else {
     res += " { " + item_name + " }";
     res += " [" + item_ordinal.ToDebugString() + "]";
     if (!parent_id.empty())
       res += " <" + parent_id.substr(0, 8) + ">";
   }
   return res;
 }
 
 }  // namespace app_list