CSS Shape renders incorrectly when scrolling

CSS Shape renders incorrectly when scrolling

While rendering, scrollOffset was taken into account. This lead to wrong points for creation of the shape.

Patch proposes removing of scrollOffset to avoid the behavior.

BUG=392857
R=pfeldman
TEST=Circle should render similarly, inspite of a scroll.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178460

[Habib Virji, 2014-07-17 13:29:05]

A small patch to correct behavior of showing CSS shape as it was taking into
scrollOffset.

[lushnikov, 2014-07-17 19:05:36]

lgtm

https://codereview.chromium.org/396803010/diff/1/LayoutTests/inspector/elemen...
File LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll.html
(right):

https://codereview.chromium.org/396803010/diff/1/LayoutTests/inspector/elemen...
LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll.html:27:
InspectorTest.selectNodeWithId('circle', function(node) {
please, extract to named functions - we generally avoid anonymous functions.

[Habib Virji, 2014-07-18 08:36:44]

The CQ bit was checked by habib.virji@samsung.com

[commit-bot: I haz the power, 2014-07-18 08:37:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/habib.virji@samsung.com/396803010/20001

[commit-bot: I haz the power, 2014-07-18 09:43:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16078)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17666)

[commit-bot: I haz the power, 2014-07-18 09:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 09:46:19]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[Habib Virji, 2014-07-18 14:13:36]

pfeldman: can you please check if this patch is okay.

[pfeldman, 2014-07-18 15:56:58]

lgtm

[Habib Virji, 2014-07-18 16:02:32]

The CQ bit was checked by habib.virji@samsung.com

[Habib Virji, 2014-07-18 16:02:44]

On 2014/07/18 15:56:58, pfeldman wrote:
> lgtm

Thanks.

[commit-bot: I haz the power, 2014-07-18 16:03:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/habib.virji@samsung.com/396803010/20001

[commit-bot: I haz the power, 2014-07-18 16:38:46]

Change committed as 178460