Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Side by Side Diff: Source/core/inspector/InspectorOverlay.cpp

Issue 396803010: CSS Shape renders incorrectly when scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed the anonymous function from the test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 return result.release(); 487 return result.release();
488 } 488 }
489 489
490 // CSS shapes 490 // CSS shapes
491 static void appendPathCommandAndPoints(PathApplyInfo* info, const String& comman d, const FloatPoint points[], unsigned length) 491 static void appendPathCommandAndPoints(PathApplyInfo* info, const String& comman d, const FloatPoint points[], unsigned length)
492 { 492 {
493 FloatPoint point; 493 FloatPoint point;
494 info->array->addItem(JSONString::create(command)); 494 info->array->addItem(JSONString::create(command));
495 for (unsigned i = 0; i < length; i++) { 495 for (unsigned i = 0; i < length; i++) {
496 point = info->shapeOutsideInfo->shapeToRendererPoint(points[i]); 496 point = info->shapeOutsideInfo->shapeToRendererPoint(points[i]);
497 point = info->view->contentsToRootView(roundedIntPoint(info->renderer->l ocalToAbsolute(point))) + info->rootView->scrollOffset(); 497 point = info->view->contentsToRootView(roundedIntPoint(info->renderer->l ocalToAbsolute(point)));
498 info->array->addItem(JSONBasicValue::create(point.x())); 498 info->array->addItem(JSONBasicValue::create(point.x()));
499 info->array->addItem(JSONBasicValue::create(point.y())); 499 info->array->addItem(JSONBasicValue::create(point.y()));
500 } 500 }
501 } 501 }
502 502
503 static void appendPathSegment(void* info, const PathElement* pathElement) 503 static void appendPathSegment(void* info, const PathElement* pathElement)
504 { 504 {
505 PathApplyInfo* pathApplyInfo = static_cast<PathApplyInfo*>(info); 505 PathApplyInfo* pathApplyInfo = static_cast<PathApplyInfo*>(info);
506 FloatPoint point; 506 FloatPoint point;
507 switch (pathElement->type) { 507 switch (pathElement->type) {
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
792 hideHighlight(); 792 hideHighlight();
793 } 793 }
794 794
795 void InspectorOverlay::startedRecordingProfile() 795 void InspectorOverlay::startedRecordingProfile()
796 { 796 {
797 if (!m_activeProfilerCount++) 797 if (!m_activeProfilerCount++)
798 freePage(); 798 freePage();
799 } 799 }
800 800
801 } // namespace WebCore 801 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698