Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 396753005: Keep all references to kInstallDate inside components/metrics/ (Closed)

Created:
6 years, 5 months ago by gab
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Ilya Sherman
Project:
chromium
Visibility:
Public.

Description

Keep all references to kInstallDate inside components/metrics/ Follow-up to https://codereview.chromium.org/370813003/ as per request. BUG=391338 TEST=kInstallDate is still set on startup when it wasn't previously set (and no backup is present in registry) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -28 lines) Patch
M chrome/browser/chrome_browser_field_trials.h View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_field_trials.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/chrome_browser_field_trials_desktop.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials_desktop.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials_mobile.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chrome_browser_field_trials_mobile.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M components/metrics/metrics_service.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gab
As requested post-commit in https://codereview.chromium.org/370813003/
6 years, 5 months ago (2014-07-15 22:12:52 UTC) #1
Alexei Svitkine (slow)
LGTM, thanks!
6 years, 5 months ago (2014-07-15 23:00:42 UTC) #2
gab
The CQ bit was checked by gab@chromium.org
6 years, 5 months ago (2014-07-15 23:59:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/396753005/1
6 years, 5 months ago (2014-07-16 00:02:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 11:22:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 11:26:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80235)
6 years, 5 months ago (2014-07-16 11:26:33 UTC) #7
gab
@thestig for chrome_browser_main.cc (please CQ if it LGTY) Thanks! Gab
6 years, 5 months ago (2014-07-16 14:25:37 UTC) #8
Lei Zhang
lgtm stampy stamp
6 years, 5 months ago (2014-07-16 18:07:46 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 19:14:39 UTC) #10
Message was sent while issue was closed.
Change committed as 283467

Powered by Google App Engine
This is Rietveld 408576698