Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 381113004: Add chrome/browser/ui to the GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
awong
CC:
chromium-reviews, sadrul, tzik, tfarina, jam, nhiroki, kinuko+fileapi, darin-cc_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, android-webview-reviews_chromium.org, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add chrome/browser/ui to the GN build. This moves the intermediate grit files: ui/ui_resources -> ui/resources ui/ui_strings -> ui/strings in the GYP build to put it in line with the GN one (and also what one would expect). R=ajwong@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282663

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+602 lines, -77 lines) Patch
M BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M android_webview/android_webview.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/shell/app_shell.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/BUILD.gn View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M ash/ash.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_strings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + ash/resources/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ash/strings/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M build/config/BUILD.gn View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M build/config/features.gni View 2 chunks +12 lines, -0 lines 0 comments Download
M build/config/ui.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M build/ui_resources_location.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/BUILD.gn View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/ui/BUILD.gn View 1 2 1 chunk +421 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 12 chunks +22 lines, -23 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 5 chunks +5 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/repack_locales.py View 1 chunk +2 lines, -2 lines 0 comments Download
M components/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M components/feedback.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A components/feedback/BUILD.gn View 1 chunk +37 lines, -0 lines 0 comments Download
A + components/feedback/proto/BUILD.gn View 1 chunk +8 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M printing/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M ui/resources/ui_resources.gyp View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/strings/ui_strings.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tapted
(comments: just some whitespace things git complained about when I patched this in; if you're ...
6 years, 5 months ago (2014-07-11 04:06:21 UTC) #1
brettw
Thanks for your interest! mac+views is too much for me to worry about now (can ...
6 years, 5 months ago (2014-07-11 16:37:45 UTC) #2
awong
rubberstamp LGTM
6 years, 5 months ago (2014-07-11 19:07:23 UTC) #3
brettw
6 years, 5 months ago (2014-07-11 19:23:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r282663.

Powered by Google App Engine
This is Rietveld 408576698