Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 396703002: Makes Embed() take a single node (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Makes Embed() take a single node This simplifies things and better matches how we're actually using the API. BUG=389339 TEST=covered by unit tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283313

Patch Set 1 #

Patch Set 2 : OnRootsAdded->OnRootAdded #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -108 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 2 2 chunks +7 lines, -8 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 2 6 chunks +9 lines, -10 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 5 chunks +29 lines, -46 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 6 chunks +17 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 5 months ago (2014-07-15 16:35:29 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 5 months ago (2014-07-15 16:40:31 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 5 months ago (2014-07-15 16:45:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/396703002/40001
6 years, 5 months ago (2014-07-15 16:47:35 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 01:07:15 UTC) #5
Message was sent while issue was closed.
Change committed as 283313

Powered by Google App Engine
This is Rietveld 408576698