Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 396703002: Makes Embed() take a single node (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index f1121b61dca69cd50be7c216d27d0fc9bd9cf501..6c8af5c5d49e0bdf336eb94f4c57265cb639544b 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -126,15 +126,14 @@ interface ViewManagerService {
// Sets focus to the specified node.
SetFocus(uint32 node_id) => (bool success);
- // Embeds the app at |url| in the specified nodes. More specifically this
+ // Embeds the app for |url| in the specified node. More specifically this
// creates a new connection to the specified url, expecting to get an
- // ViewManagerClient and configures it with the root nodes |nodes|. Fails
- // if |nodes| is empty or contains nodes that were not created by this
- // connection.
+ // ViewManagerClient and configures it with the root node |node|. Fails
+ // if |node| was not created by this connection.
// If a particular client invokes Embed() multiple times with the same url,
// the connection is reused. When this happens the ViewManagerClient is
- // notified of the additional roots by way of OnRootsAdded().
- Embed(string url, uint32[] nodes) => (bool success);
+ // notified of the additional roots by way of OnRootAdded().
+ Embed(string url, uint32 node_id) => (bool success);
// TODO(sky): move these to a separate interface when FIFO works.
@@ -156,9 +155,9 @@ interface ViewManagerClient {
uint32 next_server_change_id,
NodeData[] nodes);
- // See description of ViewManagerService::Connect() for details as to when
+ // See description of ViewManagerService::Embed() for details as to when
// this is invoked.
- OnRootsAdded(NodeData[] nodes);
+ OnRootAdded(NodeData[] nodes);
// This is sent to clients when a change is made to the server that results
// in the |server_change_id| changing but the client isn't notified. This is
« no previous file with comments | « mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc ('k') | mojo/services/view_manager/root_node_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698