Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 396493003: Revert 283052 "Add browser_extensions to GN build." (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 283052 "Add browser_extensions to GN build." > Add browser_extensions to GN build. > > BUG= > R=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/383083010 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+918 lines, -1217 lines) Patch
M trunk/src/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/build/config/features.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/build/config/linux/BUILD.gn View 2 chunks +0 lines, -17 lines 0 comments Download
M trunk/src/chrome/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D trunk/src/chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -224 lines 0 comments Download
D trunk/src/chrome/browser/extensions/api/cast_channel/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/ui/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 7 chunks +912 lines, -948 lines 0 comments Download
M trunk/src/chrome/common/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/components/onc.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/components/onc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/extensions/common/api/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/extensions/common/api/api.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 5 months ago (2014-07-14 22:37:44 UTC) #1
brettw
6 years, 5 months ago (2014-07-14 22:37:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r283057 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698