Issue 383083010: Add browser_extensions to GN build.

Issue 383083010: Add browser_extensions to GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add browser_extensions to GN build. BUG= R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283052

Patch Set 2 : comment fix #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1210 lines, -921 lines)			Patch
M	BUILD.gn	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	build/config/features.gni	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/config/linux/BUILD.gn	View		2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/BUILD.gn	View		2 chunks	+1 line, -1 line	0 comments	Download
A	chrome/browser/extensions/BUILD.gn	View	1	1 chunk	+224 lines, -0 lines	0 comments	Download
A +	chrome/browser/extensions/api/cast_channel/BUILD.gn	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/BUILD.gn	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		7 chunks	+948 lines, -912 lines	0 comments	Download
M	chrome/common/BUILD.gn	View		2 chunks	+1 line, -1 line	0 comments	Download
M	components/onc.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/onc/BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/common/api/BUILD.gn	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	extensions/common/api/api.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/383083010/diff/1/chrome/browser/extensions/BUILD.gn File chrome/browser/extensions/BUILD.gn (right): https://codereview.chromium.org/383083010/diff/1/chrome/browser/extensions/BUILD.gn#newcode22 chrome/browser/extensions/BUILD.gn:22: # TODO(GYP) remove this when wevbrtc is ported. ...

6 years, 5 months ago (2014-07-14 21:12:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r283052.

Expand Messages | Collapse Messages