[MIPS] Do not force clang for mipsel Linux

[MIPS] Do not force clang for mipsel Linux

Fix the MIPS Linux build that was broken by r282266 (and r282246).
Related r282266 review is at https://codereview.chromium.org/382743002

TEST= build Chrome Linux for target_arch=mipsel

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283645

[petarj, 2014-07-16 13:14:04]

PTAL.

[Nico, 2014-07-16 13:41:18]

Broken in what way? Can it be fixed instead? (I don't know how well clang
supports MIPS.)
On Jul 16, 2014 6:14 AM, <petarj@mips.com> wrote:

> Reviewers: Yuta Kitamura, Nico (away),
>
> Message:
> PTAL.
>
> Description:
> [MIPS] Do not force clang for mipsel Linux
>
> Fix the MIPS Linux build that was broken by r282266.
> Related r282266 review is at https://codereview.chromium.org/382743002
>
> TEST= build Chrome Linux for target_arch=mipsel
>
> Please review this at https://codereview.chromium.org/396243002/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -1 lines):
>   M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index 92effa3d76bb704605ccb1f361f179ef33ab1585..
> 0746161a21cac1bad92af5676f57603cee1b72a6 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -1783,7 +1783,7 @@
>          # the class names, so the JNI generator needs to know this.
>          'jni_generator_jarjar_file': '../android_webview/build/
> jarjar-rules.txt',
>        }],
> -      ['OS=="linux"', {
> +      ['OS=="linux" and target_arch!="mipsel"', {
>          # TODO(thakis): This is here to measure perf for a while.
>          'clang%': 1,
>        }],  # OS=="mac"
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[petarj, 2014-07-16 14:06:56]

On 2014/07/16 13:41:18, Nico (away) wrote:
> Broken in what way? Can it be fixed instead? (I don't know how well clang
> supports MIPS.)

Here is the log [1]. Clang does support MIPS, but we do not have it in the
mipsel-sysroot today.

[1] MIPS Chrome Linux buildbot failure, 
http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for...

[Nico, 2014-07-16 17:18:27]

Does removing the

    ['OS=="linux" and target_arch=="mipsel"', {
      'make_global_settings': [
        ['CC', '<(sysroot)/../bin/mipsel-linux-gnu-gcc'],
        ['CXX', '<(sysroot)/../bin/mipsel-linux-gnu-g++'],
        ['CC.host', '<!(which gcc)'],
        ['CXX.host', '<!(which g++)'],
      ],

block work as well?

[petarj, 2014-07-16 20:03:58]

On 2014/07/16 17:18:27, Nico (away) wrote:
> Does removing the
> 
>     ['OS=="linux" and target_arch=="mipsel"', {
>       'make_global_settings': [
>         ['CC', '<(sysroot)/../bin/mipsel-linux-gnu-gcc'],
>         ['CXX', '<(sysroot)/../bin/mipsel-linux-gnu-g++'],
>         ['CC.host', '<!(which gcc)'],
>         ['CXX.host', '<!(which g++)'],
>       ],
> 
> block work as well?

This will give a new set of errors such as:
clang: error: unsupported argument '-mips32' to option 'Wa,'
etc.
We have not tried to build Chrome for MIPS Linux yet.

Speaking of which, isn't the Clang inside of the tree:
third_party/llvm-build/Release+Asserts/

configured for host-only target?

[Nico, 2014-07-16 20:08:05]

On 2014/07/16 20:03:58, petarj wrote:
> On 2014/07/16 17:18:27, Nico (away) wrote:
> > Does removing the
> > 
> >     ['OS=="linux" and target_arch=="mipsel"', {
> >       'make_global_settings': [
> >         ['CC', '<(sysroot)/../bin/mipsel-linux-gnu-gcc'],
> >         ['CXX', '<(sysroot)/../bin/mipsel-linux-gnu-g++'],
> >         ['CC.host', '<!(which gcc)'],
> >         ['CXX.host', '<!(which g++)'],
> >       ],
> > 
> > block work as well?
> 
> This will give a new set of errors such as:
> clang: error: unsupported argument '-mips32' to option 'Wa,'
> etc.
> We have not tried to build Chrome for MIPS Linux yet.

You mean "Chrome for MIPS Linux with clang"? Or is this patch for android?

If did mean "Chrome for MIPS Linux with clang", then this patch lgtm (since the
mips bot is out-of-tree, it's up to you what you do there :-) ).

> 
> Speaking of which, isn't the Clang inside of the tree:
> third_party/llvm-build/Release+Asserts/
> 
> configured for host-only target?

No. You can look at tools/clang/scripts/update.sh to see the configure line. It
does a bootstrap build, and the bootstrap compiler is host-only, but the final
compiler is built with support for all targets.

[petarj, 2014-07-16 20:20:54]

On 2014/07/16 20:08:05, Nico (away) wrote:
> You mean "Chrome for MIPS Linux with clang"? 

Yes, that's what I meant.
Building with clang may require some tuning in terms what options we pass
and such.

> Or is this patch for android?
> 

No.

> No. You can look at tools/clang/scripts/update.sh to see the configure line.
It
> does a bootstrap build, and the bootstrap compiler is host-only, but the final
> compiler is built with support for all targets.

I see now. Thanks.

Cheers,
Petar

[petarj, 2014-07-16 20:54:33]

The CQ bit was checked by petarj@mips.com

[commit-bot: I haz the power, 2014-07-16 20:59:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/petarj@mips.com/396243002/1

[commit-bot: I haz the power, 2014-07-17 04:42:32]

Change committed as 283645