Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 382743002: Revert of Revert of Turn on clang by default on linux, 3rd try. (Closed)

Created:
6 years, 5 months ago by Yuta Kitamura
Modified:
6 years, 5 months ago
Reviewers:
Nico, awong1, horo
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Turn on clang by default on linux, 3rd try. (https://codereview.chromium.org/378363006/) Reason for revert: This change should not have been reverted, since it was easy to just disable these tests. thakis explicitly requested "please ping thakis before reverting it". Original issue's description: > Revert of Turn on clang by default on linux, 3rd try. (https://codereview.chromium.org/379413002/) > > Reason for revert: > NaClBrowserTestNonSfiMode.Messaging and NaClBrowserTestNonSfiMode.Irt failed. > > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Irt > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Messaging > > Original issue's description: > > Turn on clang by default on linux, 3rd try. > > > > This is mostly to collect performance and size data for now, and to find out > > if more bots need work. Unless things look really good, I'm going to revert > > this by thursday morning (PDT). > > > > BUG=360311 > > TBR=ajwong@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282246 > > TBR=awong@chromium.org,thakis@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=360311 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282265 TBR=awong@chromium.org,thakis@chromium.org,horo@chromium.org NOTREECHECKS=true NOTRY=true BUG=360311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yuta Kitamura
Created Revert of Revert of Turn on clang by default on linux, 3rd try.
6 years, 5 months ago (2014-07-10 07:34:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yutak@chromium.org/382743002/1
6 years, 5 months ago (2014-07-10 07:34:49 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 07:36:44 UTC) #3
Message was sent while issue was closed.
Change committed as 282266

Powered by Google App Engine
This is Rietveld 408576698