Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: runtime/vm/stack_frame.cc

Issue 396213005: Fix PcDescriptor iteratot to never return a pointer to a memory location since the data can move wi… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/simulator_arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_frame.cc
===================================================================
--- runtime/vm/stack_frame.cc (revision 38336)
+++ runtime/vm/stack_frame.cc (working copy)
@@ -226,7 +226,8 @@
descriptors = code.pc_descriptors();
PcDescriptors::Iterator iter(descriptors, RawPcDescriptors::kAnyKind);
while (iter.HasNext()) {
- const RawPcDescriptors::PcDescriptorRec& rec = iter.Next();
+ RawPcDescriptors::PcDescriptorRec rec;
+ iter.NextRec(&rec);
if ((rec.pc() == pc()) && (rec.try_index() != -1)) {
RawExceptionHandlers::HandlerInfo handler_info;
handlers.GetHandlerInfo(rec.try_index(), &handler_info);
@@ -250,7 +251,8 @@
ASSERT(!descriptors.IsNull());
PcDescriptors::Iterator iter(descriptors, RawPcDescriptors::kAnyKind);
while (iter.HasNext()) {
- const RawPcDescriptors::PcDescriptorRec& rec = iter.Next();
+ RawPcDescriptors::PcDescriptorRec rec;
+ iter.NextRec(&rec);
if (rec.pc() == pc()) {
return rec.token_pos();
}
« no previous file with comments | « runtime/vm/simulator_arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698