runtime/vm/simulator_arm.cc - Issue 396213005: Fix PcDescriptor iteratot to never return a pointer to a memory location since the data can move wi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/simulator_arm.cc

Issue 396213005: Fix PcDescriptor iteratot to never return a pointer to a memory location since the data can move wi… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/simulator_arm.cc

===================================================================

--- runtime/vm/simulator_arm.cc (revision 38336)

+++ runtime/vm/simulator_arm.cc (working copy)

@@ -271,7 +271,8 @@

PcDescriptors::Handle(code.pc_descriptors());

PcDescriptors::Iterator iter(descriptors, RawPcDescriptors::kAnyKind);

while (iter.HasNext()) {

- const RawPcDescriptors::PcDescriptorRec& rec = iter.Next();

+ RawPcDescriptors::PcDescriptorRec rec;

+ iter.NextRec(&rec);

if (rec.pc() == pc) {

return rec.token_pos();

} else if ((token_pos <= 0) && (rec.pc() > pc)) {

« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »