Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 396063009: Context Menu "Open image" doesn't make sense in a Image URL Tab (Closed)

Created:
6 years, 5 months ago by ankit
Modified:
6 years, 5 months ago
Reviewers:
Ted C, Bernhard Bauer
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org, AKVT, AviD, Cyan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Context Menu "Open image" doesn't make sense in a Image URL Tab When only image is opened then on long press context menu appears. From context menu on selection of "open image" page reloads which does not make sense.Added condition to hide option "open image" if page url and image url for which context menu appears is same. BUG=270682 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283534

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated comment as suggested #

Messages

Total messages: 8 (0 generated)
ankit
PTAL
6 years, 5 months ago (2014-07-16 07:11:07 UTC) #1
Bernhard Bauer
LGTM, thanks!
6 years, 5 months ago (2014-07-16 08:05:59 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/396063009/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java File chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java (right): https://codereview.chromium.org/396063009/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java#newcode78 chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:78: if (mDelegate.getPageUrl().equals(params.getSrcUrl())) { You could add a comment here ...
6 years, 5 months ago (2014-07-16 08:06:27 UTC) #3
ankit
@Bernhard PTAL new patch set.
6 years, 5 months ago (2014-07-16 08:57:11 UTC) #4
Bernhard Bauer
LGTM!
6 years, 5 months ago (2014-07-16 09:01:12 UTC) #5
ankit
The CQ bit was checked by ankit2.kumar@samsung.com
6 years, 5 months ago (2014-07-16 09:01:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/396063009/20001
6 years, 5 months ago (2014-07-16 09:03:36 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 21:58:18 UTC) #8
Message was sent while issue was closed.
Change committed as 283534

Powered by Google App Engine
This is Rietveld 408576698