chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java - Issue 396063009: Context Menu "Open image" doesn't make sense in a Image URL Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 396063009: Context Menu "Open image" doesn't make sense in a Image URL Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated comment as suggested Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItemDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/EmptyChromeContextMenuItemDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

index 496e81def3560abef6d80be3a63d260d90c79725..6ef4fcdda74e24240866b4ff7f80b046ff20765b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

@@ -75,6 +75,10 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

menu.findItem(R.id.contextmenu_open_original_image_in_new_tab).setVisible(false);

}

+ // Avoid showing open image option for same image which is already opened.

+ if (mDelegate.getPageUrl().equals(params.getSrcUrl())) {

+ menu.findItem(R.id.contextmenu_open_image).setVisible(false);

+ }

final TemplateUrlService templateUrlServiceInstance = TemplateUrlService.getInstance();

final boolean isSearchByImageAvailable =

UrlUtilities.isDownloadableScheme(params.getSrcUrl()) &&