Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 395933003: Fix TestChannelIDKey ASan failure under OpenSSL. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix TestChannelIDKey ASan failure under OpenSSL. EVP_MD_CTX has two sets of cleanup functions, depending on whether it's heap- or stack-allocated. BUG=393962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M net/quic/test_tools/crypto_test_utils_openssl.cc View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
I hope you don't mind my stealing your bug. :-)
6 years, 5 months ago (2014-07-15 19:19:23 UTC) #1
Ryan Sleevi
lgtm
6 years, 5 months ago (2014-07-15 19:45:56 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-15 19:50:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/395933003/1
6 years, 5 months ago (2014-07-15 19:52:46 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 05:30:48 UTC) #5
Message was sent while issue was closed.
Change committed as 283358

Powered by Google App Engine
This is Rietveld 408576698