Fix TestChannelIDKey ASan failure under OpenSSL.

net/quic/test_tools/crypto_test_utils_openssl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/test_tools/crypto_test_utils.h"
 
 #include <openssl/bn.h>
 #include <openssl/ec.h>
 #include <openssl/ecdsa.h>
 #include <openssl/evp.h>
@@ skipping 14 matching lines @@
 
 class TestChannelIDKey : public ChannelIDKey {
  public:
   explicit TestChannelIDKey(EVP_PKEY* ecdsa_key) : ecdsa_key_(ecdsa_key) {}
   virtual ~TestChannelIDKey() OVERRIDE {}
 
   // ChannelIDKey implementation.
 
   virtual bool Sign(StringPiece signed_data,
                     string* out_signature) const OVERRIDE {
-    EVP_MD_CTX md_ctx;
-    EVP_MD_CTX_init(&md_ctx);
-    crypto::ScopedEVP_MD_CTX md_ctx_cleanup(&md_ctx);
-
-    if (EVP_DigestSignInit(&md_ctx, NULL, EVP_sha256(), NULL,
+    crypto::ScopedEVP_MD_CTX md_ctx(EVP_MD_CTX_create());
+    if (!md_ctx ||
+        EVP_DigestSignInit(md_ctx.get(), NULL, EVP_sha256(), NULL,
                            ecdsa_key_.get()) != 1) {
       return false;
     }
 
-    EVP_DigestUpdate(&md_ctx, ChannelIDVerifier::kContextStr,
+    EVP_DigestUpdate(md_ctx.get(), ChannelIDVerifier::kContextStr,
                      strlen(ChannelIDVerifier::kContextStr) + 1);
-    EVP_DigestUpdate(&md_ctx, ChannelIDVerifier::kClientToServerStr,
+    EVP_DigestUpdate(md_ctx.get(), ChannelIDVerifier::kClientToServerStr,
                      strlen(ChannelIDVerifier::kClientToServerStr) + 1);
-    EVP_DigestUpdate(&md_ctx, signed_data.data(), signed_data.size());
+    EVP_DigestUpdate(md_ctx.get(), signed_data.data(), signed_data.size());
 
     size_t sig_len;
-    if (!EVP_DigestSignFinal(&md_ctx, NULL, &sig_len)) {
+    if (!EVP_DigestSignFinal(md_ctx.get(), NULL, &sig_len)) {
       return false;
     }
 
     scoped_ptr<uint8[]> der_sig(new uint8[sig_len]);
-    if (!EVP_DigestSignFinal(&md_ctx, der_sig.get(), &sig_len)) {
+    if (!EVP_DigestSignFinal(md_ctx.get(), der_sig.get(), &sig_len)) {
       return false;
     }
 
     uint8* derp = der_sig.get();
     crypto::ScopedECDSA_SIG sig(
         d2i_ECDSA_SIG(NULL, const_cast<const uint8**>(&derp), sig_len));
     if (sig.get() == NULL) {
       return false;
     }
 
@@ skipping 92 matching lines @@
 };
 
 // static
 ChannelIDSource* CryptoTestUtils::ChannelIDSourceForTesting() {
   return new TestChannelIDSource();
 }
 
 }  // namespace test
 
 }  // namespace net