Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 395893002: Convert results.Add to results.AddValue for files in web_perf/ (Closed)

Created:
6 years, 5 months ago by nednguyen
Modified:
6 years, 5 months ago
Reviewers:
nduca, chrishenry
CC:
chromium-reviews, eakuefner, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert results.Add to results.AddValue for files in web_perf/ BUG=346958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283737

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix styling nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -34 lines) Patch
M tools/telemetry/telemetry/web_perf/metrics/fast_metric.py View 3 chunks +7 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py View 2 chunks +7 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness.py View 2 chunks +25 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 1 chunk +9 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 2 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nednguyen
6 years, 5 months ago (2014-07-15 17:55:17 UTC) #1
chrishenry
lgtm in advance, but see comments below. https://codereview.chromium.org/395893002/diff/1/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py File tools/telemetry/telemetry/web_perf/timeline_based_measurement.py (right): https://codereview.chromium.org/395893002/diff/1/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py#newcode49 tools/telemetry/telemetry/web_perf/timeline_based_measurement.py:49: #TODO(nednguyen): Get ...
6 years, 5 months ago (2014-07-16 17:38:36 UTC) #2
nednguyen
https://codereview.chromium.org/395893002/diff/1/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py File tools/telemetry/telemetry/web_perf/timeline_based_measurement.py (right): https://codereview.chromium.org/395893002/diff/1/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py#newcode49 tools/telemetry/telemetry/web_perf/timeline_based_measurement.py:49: #TODO(nednguyen): Get rid of this results wrapper hack after ...
6 years, 5 months ago (2014-07-16 17:46:26 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-16 17:46:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/395893002/20001
6 years, 5 months ago (2014-07-16 17:49:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 17:49:15 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-16 17:49:16 UTC) #7
nduca
lgtm
6 years, 5 months ago (2014-07-16 18:08:36 UTC) #8
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-16 18:08:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/395893002/20001
6 years, 5 months ago (2014-07-16 18:12:59 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 10:20:41 UTC) #11
Message was sent while issue was closed. 
Change committed as 283737

Powered by Google App Engine
This is Rietveld 408576698