Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 395893002: Convert results.Add to results.AddValue for files in web_perf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix styling nit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
index 87527f1e1d8095daf134e918eb5f5508d462ed5e..226dc222db1a27f3e6ac8b39955aa977744b92d3 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
@@ -46,23 +46,23 @@ def _GetMetricFromMetricType(metric_type):
raise Exception('Unrecognized metric type: %s' % metric_type)
+# TODO(nednguyen): Get rid of this results wrapper hack after we add interaction
+# record to telemetry value system.
class _ResultsWrapper(object):
def __init__(self, results, label):
self._results = results
self._result_prefix = label
+ @property
+ def current_page(self):
+ return self._results.current_page
+
def _GetResultName(self, trace_name):
return '%s-%s' % (self._result_prefix, trace_name)
- def Add(self, trace_name, units, value, chart_name=None, data_type='default'):
- result_name = self._GetResultName(trace_name)
- self._results.Add(result_name, units, value, chart_name, data_type)
-
- def AddSummary(self, trace_name, units, value, chart_name=None,
- data_type='default'):
- result_name = self._GetResultName(trace_name)
- self._results.AddSummary(result_name, units, value, chart_name, data_type)
-
+ def AddValue(self, value):
+ value.name = self._GetResultName(value.name)
+ self._results.AddValue(value)
class _TimelineBasedMetrics(object):
def __init__(self, model, renderer_thread,

Powered by Google App Engine
This is Rietveld 408576698