Source/core/svg/SVGFEPointLightElement.cpp - Issue 395813002: Resolve light-source position/direction when updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGFEPointLightElement.cpp

Issue 395813002: Resolve light-source position/direction when updated (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGFEPointLightElement.cpp

diff --git a/Source/core/svg/SVGFEPointLightElement.cpp b/Source/core/svg/SVGFEPointLightElement.cpp

index 79c43e74d6f037292a48b565908c1efbfd92dfd2..68e0358ca3328723a0d7ab8de0fe36877668f375 100644

--- a/Source/core/svg/SVGFEPointLightElement.cpp

+++ b/Source/core/svg/SVGFEPointLightElement.cpp

@@ -36,8 +36,7 @@ DEFINE_NODE_FACTORY(SVGFEPointLightElement)

PassRefPtr<LightSource> SVGFEPointLightElement::lightSource(Filter* filter) const

{

- FloatPoint3D location(x()->currentValue()->value(), y()->currentValue()->value(), z()->currentValue()->value());

- return PointLightSource::create(filter->resolve3dPoint(location));

+ return PointLightSource::create(filter->resolve3dPoint(position()));

}