[DevTools] Move DevToolsWindow testing code to a separate class.

[DevTools] Move DevToolsWindow testing code to a separate class.

This change:
- allows for proper docking testing (including toolbox);
- removes all test friends from DevToolsWindow;
- unifies testing approach to use load callback instead of notifications;
- adds simple toolbox tests.

BUG=393566
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284423

[dgozman, 2014-07-15 14:22:16]

Take a look please.

[pfeldman, 2014-07-16 08:48:57]

https://codereview.chromium.org/395783002/diff/60001/chrome/browser/devtools/...
File chrome/browser/devtools/devtools_window_testing.h (right):

https://codereview.chromium.org/395783002/diff/60001/chrome/browser/devtools/...
chrome/browser/devtools/devtools_window_testing.h:21: class
DevToolsWindowTesting {
Can we place those static methods in a new devtools_test_utils namespace
instead?

[pfeldman, 2014-07-16 15:22:24]

lgtm

[dgozman, 2014-07-17 13:59:14]

Scott, could you please take a look as a chrome/ owner?

[sky, 2014-07-17 16:14:40]

I assume you mean everything not under devtools. The rest of things LGTM

https://codereview.chromium.org/395783002/diff/100001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/395783002/diff/100001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:1026: 'browser/devtools/devtools_window_testing.h',
.h after .cc

[dgozman, 2014-07-17 16:30:02]

https://codereview.chromium.org/395783002/diff/100001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/395783002/diff/100001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:1026: 'browser/devtools/devtools_window_testing.h',
On 2014/07/17 16:14:40, sky wrote:
> .h after .cc

Done.

[dgozman, 2014-07-17 16:30:19]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-07-17 16:32:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/395783002/120001

[commit-bot: I haz the power, 2014-07-17 21:05:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-17 21:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 21:24:41]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[dgozman, 2014-07-18 06:00:18]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-07-18 06:01:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/395783002/120001

[commit-bot: I haz the power, 2014-07-18 06:25:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-18 06:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 06:46:11]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[dgozman, 2014-07-18 10:36:39]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-07-18 10:37:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/395783002/120001

[commit-bot: I haz the power, 2014-07-18 10:38:28]

Change committed as 284050

[gab, 2014-07-18 18:57:40]

A revert of this CL has been created in
https://codereview.chromium.org/403833002/ by gab@chromium.org.

The reason for reverting is: Mac 10.7 has become flaky for ViewIDTest.Basic
(http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%282%29?n...)
and this CL is suspected as it touches this exact test.

Example crash stack trace below:

BrowserTestBase signal handler received SIGTERM. Backtrace:
0   browser_tests                       0x0132e9ba
base::debug::StackTrace::StackTrace() + 26
1   browser_tests                       0x04e5ecb8
_ZN7content12_GLOBAL__N_1L27DumpStackTraceSignalHandlerEi + 72
2   libsystem_c.dylib                   0x9090259b _sigtramp + 43
3   ???                                 0xffffffff 0x0 + 4294967295
4   browser_tests                       0x01328f56
base::AtExitManager::RegisterCallback(void (*)(void*), void*) + 102
5   browser_tests                       0x02614bb4
Singleton\u003Ccc::TaskRunnerPairs,
DefaultSingletonTraits\u003Ccc::TaskRunnerPairs>, cc::TaskRunnerPairs>::get() +
276
6   browser_tests                       0x026141e7
cc::BlockingTaskRunner::current() + 23
7   browser_tests                       0x02614762
cc::BlockingTaskRunner::CapturePostTasks::CapturePostTasks() + 18
8   browser_tests                       0x026404eb cc::SingleThreadProxy::Stop()
+ 59
9   browser_tests                       0x02619e04
cc::LayerTreeHost::~LayerTreeHost() + 132
10  browser_tests                       0x0261a2c1
cc::LayerTreeHost::~LayerTreeHost() + 17
11  browser_tests                       0x04011e94 ui::Compositor::~Compositor()
+ 148
12  browser_tests                       0x040120c1 ui::Compositor::~Compositor()
+ 17
13  browser_tests                       0x03fa8dfd -[BrowserCompositorViewCocoa
.cxx_destruct] + 173
14  libobjc.A.dylib                     0x995863bf object_cxxDestructFromClass +
104
15  libobjc.A.dylib                     0x99583204 objc_destructInstance + 40
16  browser_tests                       0x021dd2c2 (anonymous
namespace)::ZombieDealloc(objc_object*, objc_selector*) + 98
17  AppKit                              0x96b68b39 -[NSResponder dealloc] + 156
18  AppKit                              0x96b66fee -[NSView dealloc] + 74
19  libobjc.A.dylib                     0x9958254e _objc_rootRelease + 47
20  browser_tests                       0x03fa7f16
base::LazyInstance\u003Cbase::scoped_nsobject\u003CBrowserCompositorViewCocoa>,
base::DefaultLazyInstanceTraits\u003Cbase::scoped_nsobject\u003CBrowserCompositorViewCocoa>
> >::OnExit(void*) + 38
21  browser_tests                       0x013291e2
base::internal::Invoker\u003C1,
base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cvoid
(*)(void*)>, void ()(void*), void ()(void*)>, void
()(void*)>::Run(base::internal::BindStateBase*) + 18
22  browser_tests                       0x01328e27
base::AtExitManager::ProcessCallbacksNow() + 119
23  browser_tests                       0x01328ec2
base::AtExitManager::~AtExitManager() + 34
24  browser_tests                       0x013bbb20 base::TestSuite::~TestSuite()
+ 48
25  browser_tests                       0x00b5f783
ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) + 51
26  browser_tests                       0x012fd642 (anonymous
namespace)::ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 34
27  browser_tests                       0x04e97e42
content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 738
28  browser_tests                       0x012fd5f3 LaunchChromeTests(int,
ChromeTestSuiteRunner*, int, char**) + 67
29  browser_tests                       0x00b5f73d main + 77
30  browser_tests                       0x00039635 start + 53
31  ???                                 0x0000000b 0x0 + 11.

[dgozman, 2014-07-21 13:07:42]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-07-21 13:08:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/395783002/140001

[commit-bot: I haz the power, 2014-07-21 14:03:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[commit-bot: I haz the power, 2014-07-21 14:07:07]

Change committed as 284423