Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 395783002: [DevTools] Move DevToolsWindow testing code to a separate class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased, added cleanup to some tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 9 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
10 #include "chrome/browser/devtools/devtools_window.h" 10 #include "chrome/browser/devtools/devtools_window_testing.h"
11 #include "chrome/browser/download/download_shelf.h" 11 #include "chrome/browser/download/download_shelf.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
14 #include "chrome/browser/ui/browser_commands.h" 14 #include "chrome/browser/ui/browser_commands.h"
15 #include "chrome/browser/ui/browser_window.h" 15 #include "chrome/browser/ui/browser_window.h"
16 #include "chrome/browser/ui/cocoa/view_id_util.h" 16 #include "chrome/browser/ui/cocoa/view_id_util.h"
17 #include "chrome/common/pref_names.h" 17 #include "chrome/common/pref_names.h"
18 #include "chrome/common/url_constants.h" 18 #include "chrome/common/url_constants.h"
19 #include "chrome/test/base/in_process_browser_test.h" 19 #include "chrome/test/base/in_process_browser_test.h"
20 #include "components/bookmarks/browser/bookmark_model.h" 20 #include "components/bookmarks/browser/bookmark_model.h"
(...skipping 19 matching lines...) Expand all
40 ASSERT_TRUE(root_window_); 40 ASSERT_TRUE(root_window_);
41 NSView* view = view_id_util::GetView(root_window_, view_id); 41 NSView* view = view_id_util::GetView(root_window_, view_id);
42 EXPECT_EQ(should_have, !!view) << " Failed id=" << view_id; 42 EXPECT_EQ(should_have, !!view) << " Failed id=" << view_id;
43 } 43 }
44 44
45 void DoTest() { 45 void DoTest() {
46 // Make sure FindBar is created to test VIEW_ID_FIND_IN_PAGE_TEXT_FIELD. 46 // Make sure FindBar is created to test VIEW_ID_FIND_IN_PAGE_TEXT_FIELD.
47 chrome::ShowFindBar(browser()); 47 chrome::ShowFindBar(browser());
48 48
49 // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED 49 // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED
50 DevToolsWindow::OpenDevToolsWindowForTest(browser(), true); 50 DevToolsWindow* devtools_window =
51 DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), true);
51 52
52 // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF 53 // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF
53 browser()->window()->GetDownloadShelf()->Show(); 54 browser()->window()->GetDownloadShelf()->Show();
54 55
55 // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT 56 // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT
56 BookmarkModel* bookmark_model = 57 BookmarkModel* bookmark_model =
57 BookmarkModelFactory::GetForProfile(browser()->profile()); 58 BookmarkModelFactory::GetForProfile(browser()->profile());
58 if (bookmark_model) { 59 if (bookmark_model) {
59 if (!bookmark_model->loaded()) 60 if (!bookmark_model->loaded())
60 test::WaitForBookmarkModelToLoad(bookmark_model); 61 test::WaitForBookmarkModelToLoad(bookmark_model);
(...skipping 14 matching lines...) Expand all
75 i == VIEW_ID_TRANSLATE_BUTTON) { 76 i == VIEW_ID_TRANSLATE_BUTTON) {
76 continue; 77 continue;
77 } 78 }
78 79
79 CheckViewID(static_cast<ViewID>(i), true); 80 CheckViewID(static_cast<ViewID>(i), true);
80 } 81 }
81 82
82 CheckViewID(VIEW_ID_TAB, true); 83 CheckViewID(VIEW_ID_TAB, true);
83 CheckViewID(VIEW_ID_TAB_STRIP, true); 84 CheckViewID(VIEW_ID_TAB_STRIP, true);
84 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false); 85 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false);
86
87 DevToolsWindowTesting::CloseDevToolsWindowSync(devtools_window);
85 } 88 }
86 89
87 private: 90 private:
88 NSWindow* root_window_; 91 NSWindow* root_window_;
89 }; 92 };
90 93
91 IN_PROC_BROWSER_TEST_F(ViewIDTest, Basic) { 94 IN_PROC_BROWSER_TEST_F(ViewIDTest, Basic) {
92 ASSERT_NO_FATAL_FAILURE(DoTest()); 95 ASSERT_NO_FATAL_FAILURE(DoTest());
93 } 96 }
94 97
(...skipping 22 matching lines...) Expand all
117 } 120 }
118 121
119 // Open the 11th tab. 122 // Open the 11th tab.
120 browser()->OpenURL(OpenURLParams(GURL(url::kAboutBlankURL), 123 browser()->OpenURL(OpenURLParams(GURL(url::kAboutBlankURL),
121 Referrer(), 124 Referrer(),
122 NEW_BACKGROUND_TAB, 125 NEW_BACKGROUND_TAB,
123 content::PAGE_TRANSITION_TYPED, 126 content::PAGE_TRANSITION_TYPED,
124 false)); 127 false));
125 CheckViewID(VIEW_ID_TAB_LAST, true); 128 CheckViewID(VIEW_ID_TAB_LAST, true);
126 } 129 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698