Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: media/base/mock_filters.h

Issue 395703002: Fold {Audio|Video}Decoder::Stop() into the dtor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: minor fixes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/mock_filters.h
diff --git a/media/base/mock_filters.h b/media/base/mock_filters.h
index c74190e8dc02d9d629640b3b488bc6b28d715a8a..5b904baa804d833e1ca7ab917c7ee15e2491089c 100644
--- a/media/base/mock_filters.h
+++ b/media/base/mock_filters.h
@@ -84,9 +84,11 @@ class MockVideoDecoder : public VideoDecoder {
MOCK_METHOD2(Decode, void(const scoped_refptr<DecoderBuffer>& buffer,
const DecodeCB&));
MOCK_METHOD1(Reset, void(const base::Closure&));
- MOCK_METHOD0(Stop, void());
MOCK_CONST_METHOD0(HasAlpha, bool());
+ // Helper function to verify destructor call.
+ MOCK_METHOD0(Destroy, void());
scherkus (not reviewing) 2014/07/15 23:37:26 do we really need this? for example ... would it
xhwang 2014/07/16 03:37:22 Done.
+
private:
DISALLOW_COPY_AND_ASSIGN(MockVideoDecoder);
};
@@ -105,7 +107,9 @@ class MockAudioDecoder : public AudioDecoder {
void(const scoped_refptr<DecoderBuffer>& buffer,
const DecodeCB&));
MOCK_METHOD1(Reset, void(const base::Closure&));
- MOCK_METHOD0(Stop, void());
+
+ // Helper function to verify destructor call.
+ MOCK_METHOD0(Destroy, void());
private:
DISALLOW_COPY_AND_ASSIGN(MockAudioDecoder);

Powered by Google App Engine
This is Rietveld 408576698