Fold {Audio|Video}Decoder::Stop() into the dtor.

media/base/mock_filters.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_MOCK_FILTERS_H_
 #define MEDIA_BASE_MOCK_FILTERS_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 66 matching lines @@
   virtual ~MockVideoDecoder();
 
   // VideoDecoder implementation.
   MOCK_METHOD4(Initialize, void(const VideoDecoderConfig& config,
                                 bool low_delay,
                                 const PipelineStatusCB& status_cb,
                                 const OutputCB& output_cb));
   MOCK_METHOD2(Decode, void(const scoped_refptr<DecoderBuffer>& buffer,
                             const DecodeCB&));
   MOCK_METHOD1(Reset, void(const base::Closure&));
-  MOCK_METHOD0(Stop, void());
   MOCK_CONST_METHOD0(HasAlpha, bool());
 
+  // Helper function to verify destructor call.
+  MOCK_METHOD0(Destroy, void());

[scherkus (not reviewing), 2014/07/15 23:37:26]

do we really need this?

for example ... would it make our tests easier to write/maintain if we didn't
worry about tracking when this function gets called?

[xhwang, 2014/07/16 03:37:22]

Done.

+
  private:
   DISALLOW_COPY_AND_ASSIGN(MockVideoDecoder);
 };
 
 class MockAudioDecoder : public AudioDecoder {
  public:
   MockAudioDecoder();
   virtual ~MockAudioDecoder();
 
   // AudioDecoder implementation.
   MOCK_METHOD3(Initialize,
                void(const AudioDecoderConfig& config,
                     const PipelineStatusCB& status_cb,
                     const OutputCB& output_cb));
   MOCK_METHOD2(Decode,
                void(const scoped_refptr<DecoderBuffer>& buffer,
                     const DecodeCB&));
   MOCK_METHOD1(Reset, void(const base::Closure&));
-  MOCK_METHOD0(Stop, void());
+
+  // Helper function to verify destructor call.
+  MOCK_METHOD0(Destroy, void());
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MockAudioDecoder);
 };
 
 class MockVideoRenderer : public VideoRenderer {
  public:
   MockVideoRenderer();
   virtual ~MockVideoRenderer();
 
@@ skipping 93 matching lines @@
  public:
   MockStatisticsCB();
   ~MockStatisticsCB();
 
   MOCK_METHOD1(OnStatistics, void(const media::PipelineStatistics& statistics));
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_MOCK_FILTERS_H_