Fold {Audio|Video}Decoder::Stop() into the dtor.

Fold {Audio|Video}Decoder::Stop() into the dtor.

The Stop() process is already synchronous. This CL folds the Stop() call into
the dtor which simplifies a lot of code.

TBR=bbudge@chromium.org
BUG=349211
TEST=Current unittests pass.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283578

[xhwang, 2014-07-15 22:32:36]

scherkus: PTAL

schenney: PTAL at content/renderer/pepper/video_decoder_shim.cc

[scherkus (not reviewing), 2014-07-15 23:37:27]

https://codereview.chromium.org/395703002/diff/20001/media/base/mock_filters.h
File media/base/mock_filters.h (right):

https://codereview.chromium.org/395703002/diff/20001/media/base/mock_filters....
media/base/mock_filters.h:90: MOCK_METHOD0(Destroy, void());
do we really need this?

for example ... would it make our tests easier to write/maintain if we didn't
worry about tracking when this function gets called?

https://codereview.chromium.org/395703002/diff/20001/media/filters/video_rend...
File media/filters/video_renderer_impl_unittest.cc (right):

https://codereview.chromium.org/395703002/diff/20001/media/filters/video_rend...
media/filters/video_renderer_impl_unittest.cc:330: // Cannot check the current
message loop here because |message_loop_| could
but isn't message_loop_ a member variable tied to the lifetime of the class?

is this code getting called somehow after message_loop_ goes away?

https://codereview.chromium.org/395703002/diff/20001/media/filters/vpx_video_...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/395703002/diff/20001/media/filters/vpx_video_...
media/filters/vpx_video_decoder.cc:213: state_ = kUninitialized;
nit: not really needed

[xhwang, 2014-07-16 00:38:18]

rebase only

[xhwang, 2014-07-16 03:37:22]

Comments addressed. PTAL again!

https://codereview.chromium.org/395703002/diff/20001/media/base/mock_filters.h
File media/base/mock_filters.h (right):

https://codereview.chromium.org/395703002/diff/20001/media/base/mock_filters....
media/base/mock_filters.h:90: MOCK_METHOD0(Destroy, void());
On 2014/07/15 23:37:26, scherkus wrote:
> do we really need this?
> 
> for example ... would it make our tests easier to write/maintain if we didn't
> worry about tracking when this function gets called?

Done.

https://codereview.chromium.org/395703002/diff/20001/media/filters/video_rend...
File media/filters/video_renderer_impl_unittest.cc (right):

https://codereview.chromium.org/395703002/diff/20001/media/filters/video_rend...
media/filters/video_renderer_impl_unittest.cc:330: // Cannot check the current
message loop here because |message_loop_| could
On 2014/07/15 23:37:26, scherkus wrote:
> but isn't message_loop_ a member variable tied to the lifetime of the class?
> 
> is this code getting called somehow after message_loop_ goes away?

This is obsolete now. The reason of the original comment is because
message_loop_ is declared after the decoder_, so the it's destroyed before the
decoder.

https://codereview.chromium.org/395703002/diff/20001/media/filters/vpx_video_...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/395703002/diff/20001/media/filters/vpx_video_...
media/filters/vpx_video_decoder.cc:213: state_ = kUninitialized;
On 2014/07/15 23:37:26, scherkus wrote:
> nit: not really needed

Done.

[scherkus (not reviewing), 2014-07-16 17:51:49]

lgtm

[xhwang, 2014-07-16 19:51:01]

bbudge@chromium.org: Please OWNERS review changes in 

content/renderer/pepper/video_decoder_shim.cc

[xhwang, 2014-07-16 19:54:37]

On 2014/07/16 19:51:01, xhwang wrote:
> mailto:bbudge@chromium.org: Please OWNERS review changes in 
> 
> content/renderer/pepper/video_decoder_shim.cc

Actually TBRing bbudge@chromium.org since this is already approved by media/
owner and the change in video_decoder_shim.cc is trivial.

[xhwang, 2014-07-16 19:54:41]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-07-16 19:57:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xhwang@chromium.org/395703002/60001

[bbudge, 2014-07-16 19:58:49]

Pepper lgtm

[commit-bot: I haz the power, 2014-07-16 23:36:47]

Change committed as 283578