Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issue 395633002: Add browser_extensions to GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1214 lines, -921 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/config/features.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/linux/BUILD.gn View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/extensions/BUILD.gn View 1 1 chunk +225 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/api/cast_channel/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 7 chunks +951 lines, -912 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/onc.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/onc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M extensions/common/api/api.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
Same as the previous except chrome_browser_extensions_sources is renamed to chrome_browser_extensions_extensions_sources since the former collided with ...
6 years, 5 months ago (2014-07-14 22:46:39 UTC) #1
jamesr
whoops, sorry I missed that too. lgtm
6 years, 5 months ago (2014-07-14 22:54:23 UTC) #2
brettw
6 years, 5 months ago (2014-07-15 23:50:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r283277 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698