src/core/SkXfermode.cpp - Issue 395603002: Simplify flattening to just write enough to call the factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkXfermode.cpp

Issue 395603002: Simplify flattening to just write enough to call the factory (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkXfermode.cpp

diff --git a/src/core/SkXfermode.cpp b/src/core/SkXfermode.cpp

index d0208570c63502475b478b25d5de948305d555f6..01d81e08270439ea56550a2af61827605c4d2553 100644

--- a/src/core/SkXfermode.cpp

+++ b/src/core/SkXfermode.cpp

@@ -1238,6 +1238,7 @@ GrEffect* XferEffect::TestCreate(SkRandom* rand,

///////////////////////////////////////////////////////////////////////////////

+#ifdef SK_SUPPORT_LEGACY_DEEPFLATTENING

SkProcCoeffXfermode::SkProcCoeffXfermode(SkReadBuffer& buffer) : INHERITED(buffer) {

uint32_t mode32 = buffer.read32() % SK_ARRAY_COUNT(gProcCoeffs);

if (mode32 >= SK_ARRAY_COUNT(gProcCoeffs)) {

@@ -1252,6 +1253,7 @@ SkProcCoeffXfermode::SkProcCoeffXfermode(SkReadBuffer& buffer) : INHERITED(buffe

fSrcCoeff = rec.fSC;

fDstCoeff = rec.fDC;

}

+#endif

bool SkProcCoeffXfermode::asMode(Mode* mode) const {

if (mode) {