Simplify flattening to just write enough to call the factory

include/core/SkImageFilter.h

Index: include/core/SkImageFilter.h
diff --git a/include/core/SkImageFilter.h b/include/core/SkImageFilter.h
index cd34ba3f91bd55664c05ce46a6e268003e22ba8f..5e297a80de98404f2b093b9ab705b8e72d34992a 100644
--- a/include/core/SkImageFilter.h
+++ b/include/core/SkImageFilter.h
@@ -207,7 +207,7 @@ protected:
 
         bool unflatten(SkReadBuffer&, int expectedInputs = -1);
 
-        CropRect        cropRect() const { return fCropRect; }
+        const CropRect& cropRect() const { return fCropRect; }
         int             inputCount() const { return fInputs.count(); }
         SkImageFilter** inputs() const { return fInputs.get(); }
 
@@ -238,7 +238,7 @@ protected:
      */
     explicit SkImageFilter(int inputCount, SkReadBuffer& rb);
 
-    virtual void flatten(SkWriteBuffer& wb) const SK_OVERRIDE;
+    void flattenCommon(SkWriteBuffer&) const;

[Stephen White, 2014/07/17 21:29:00]

Now that we have a flattenCommon(), would it make sense to move
Common:unflatten() to SkImageFilter::unflattenCommon() for symmetry? Might
require making Common's members public, but it basically is a struct already.
Just a thought.

 
     /**
      *  This is the virtual which should be overridden by the derived class